feat(cli): add /new command with the right session reset ordering

[jaydendancer12]

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

---

if you guys could look over this and get back to me it would be appreciated, thanks!

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @jaydendancer12, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the CLI by adding a /new command, providing a clear way for users to initiate a new conversation without losing the context of their previous interaction. The implementation carefully orchestrates the session state transitions and telemetry flushing to ensure a smooth and predictable user experience, while also updating dependency metadata.

Highlights

• New CLI Command: Introduced a new /new command to the CLI, enabling users to start a fresh conversation while preserving the previous session for potential resumption.
• Session Reset Ordering: Implemented a specific order for session reset operations within the /new command: first, a SessionEndEvent is fired, then a new session ID is set, followed by resetting the chat client, clearing user hints, and finally firing a SessionStartEvent.
• Session Lifecycle Integration: Integrated the new command with the session lifecycle by adding New as a valid source for SessionStartSource and a reason for SessionEndReason.
• Dependency Updates: Updated package-lock.json by removing peer: true from several dependency entries, likely as part of general dependency management or an automated update.

Changelog

• package-lock.json
  • Removed 'peer: true' property from multiple dependency entries.
• packages/cli/src/services/BuiltinCommandLoader.test.ts
  • Added a mock for the new newCommand to ensure it's properly tested.
• packages/cli/src/services/BuiltinCommandLoader.ts
  • Imported and registered the newCommand as a built-in CLI command.
• packages/cli/src/ui/commands/newCommand.test.ts
  • Added comprehensive unit tests for the /new command, verifying session lifecycle hooks, correct ordering of session reset operations, and handling of missing configuration.
• packages/cli/src/ui/commands/newCommand.ts
  • Implemented the logic for the /new command, including firing session end/start events, resetting chat, setting a new session ID, clearing user hints, and flushing telemetry.
• packages/core/src/hooks/types.ts
  • Extended the SessionStartSource enum to include New.
  • Extended the SessionEndReason enum to include New.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new /new command to start a fresh conversation. The implementation correctly handles the session lifecycle by ending the current session, creating a new session ID, resetting the chat state, and then starting a new session. The ordering of these operations is logical and is validated by new unit tests. The changes also include necessary updates to hook-related enums and wiring for the new command. The code is well-structured and includes comprehensive tests for both the success path and graceful degradation when configuration is unavailable. I have not found any issues of high or critical severity.

[jackwotherspoon]

Hi @jaydendancer12 thanks for the contribution, there is an active PR working on this already. 😄

Going to close this in favor of it: #16848

Really appreciate the contribution, please let me know if there is another PR of yours or something else you are wanting to work on