test(cli): skipped test 'should combine and resolve paths from settings and CLI arguments' passes and should be enabled

[AdamyaSingh7]

Description

In packages/cli/src/config/config.test.ts, the test 'should combine and resolve paths from settings and CLI arguments' is marked as it.skip but the underlying implementation is correct and the test passes when enabled.

Investigation

When it.skip is changed to it, the test passes successfully as part of the full suite (191/191 tests pass). The path combining logic in loadCliConfig already correctly implements the behavior the test is verifying.

Impact

Without this test active, regressions in include directory path resolution from settings and CLI arguments would go undetected.

Fix

Changed it.skip to it on line 1908 of packages/cli/src/config/config.test.ts.

Fixes #20816

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the test coverage for the CLI configuration by enabling a test that was previously skipped. The test, which validates the correct combination and resolution of include directory paths, was found to pass successfully, indicating that the underlying implementation is sound. By activating this test, the project gains improved protection against potential regressions in a critical part of its configuration logic.

Highlights

• Test Enablement: Enabled a previously skipped test case in packages/cli/src/config/config.test.ts that verifies the combination and resolution of include directory paths from settings and CLI arguments.
• Regression Prevention: Activating this test ensures that future regressions in the logic for resolving include directory paths will be detected, improving the robustness of the CLI configuration.

Changelog

• packages/cli/src/config/config.test.ts
  • Enabled the 'should combine and resolve paths from settings and CLI arguments' test case by removing it.skip.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enables a previously skipped test case for the loadCliConfig function. The change involves removing it.skip and using it to activate a test that verifies the combination and resolution of includeDirectories from both settings and CLI arguments. This improves test coverage for this configuration logic. No issues were found in this change.

[gemini-cli]

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!