Conversation
…options …" This reverts commit 5d24d6a.
|
Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a UI flickering issue by reverting a prior change that introduced expansion persistence. The original implementation, intended to maintain UI state, inadvertently caused visual instability across various tools. By rolling back these modifications, the system's behavior for UI expansion and global keypress handling is restored to a stable state, providing a temporary solution until a more robust rendering mechanism can be integrated. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: -22 B (0%) Total Size: 25.9 MB ℹ️ View Unchanged
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts a recent feature that caused UI flickering. While the removal of the related tests is correct, the revert of the implementation in AppContainer.tsx appears to be incomplete. The change to the useKeypress priority, without reverting the corresponding logic in the handleGlobalKeypress handler, will likely introduce a critical regression. I've added a comment detailing the issue.
Note: Security Review is unavailable for this PR.
| isActive: true, | ||
| priority: KeypressPriority.Low, | ||
| }); | ||
| useKeypress(handleGlobalKeypress, { isActive: true, priority: true }); |
There was a problem hiding this comment.
This revert appears to be incomplete and will likely cause a significant regression.
By changing the priority to true without also reverting the logic inside handleGlobalKeypress, the expanded view will now collapse on every keypress, not just unhandled ones.
The problematic logic is the if (!constrainHeight) block within handleGlobalKeypress (around line 1713), which unconditionally collapses the view. With high priority, this will run before other key handlers, making it impossible to interact with the UI in an expanded state.
To complete the revert, the logic that was introduced to auto-collapse the view should also be removed from handleGlobalKeypress.
References
- Maintain consistency with existing UI behavior across components. Defer non-standard UX pattern improvements to be addressed holistically rather than in a single component.
gemini-cli
bot
added
the
status/need-issue
|
Fyi @jerop this adds too much flicker to all tool calls. We should revisit after I land some ink changes. |
|
/patch preview |
|
/patch stable |
|
✅ Patch workflow(s) dispatched successfully! 📋 Details:
🔗 Track Progress: |
|
✅ Patch workflow(s) dispatched successfully! 📋 Details:
🔗 Track Progress: |
|
🚀 Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 Patch Release Started! 📋 Release Details:
⏳ Status: The patch release is now running. You'll receive another update when it completes. 🔗 Track Progress: |
|
🚀 Patch Release Started! 📋 Release Details:
⏳ Status: The patch release is now running. You'll receive another update when it completes. 🔗 Track Progress: |
|
✅ Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
|
✅ Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
2 participants
Reverts #20559
This causes too much flicker as it impacts all tools. Until we land the updated regular buffer renderer we need to hold off on landing this.