feat(browser): update chrome-devtools-mcp#21177
feat(browser): update chrome-devtools-mcp#21177kunal-10-cloud wants to merge 8 commits intogoogle-gemini:mainfrom
Conversation
…_text Update chrome-devtools-mcp to version 0.18.1 to consume the native type_text functionality instead of the locally kept character-by-character equivalent. This allows simplification of the tools returned context for the browser agent directly replacing TypeTextDeclarativeTool with dynamic inclusion.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the browser agent's interaction with browser automation by upgrading the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the chrome-devtools-mcp dependency to version 0.18.1 and refactors the browser agent to use the native type_text tool provided by the updated MCP server. The removal of the custom TypeTextInvocation and TypeTextDeclarativeTool classes simplifies the codebase and likely improves performance. The associated test files have been updated appropriately to reflect these changes. The implementation is clean and aligns with the stated goals.
|
hi @jacob314, @gsquared94 please review this pr once whenever you get time, and let me know if any changes are required |
|
@gsquared94 are there any changes required here? |
There was a regression fixed in #21766 due to which I couldn't test this earlier. Will review again. Can you update this test to include |
Hi @gsquared94, have added the same |
|
Fixes #20587 (also). Thank you. |
|
@gsquared94 are there any more changes required? |
|
@kunal-10-cloud - I think this has been fixed by #22213 |
Summary
Update
chrome-devtools-mcpto version0.18.1and replace the customtype_texttool implementation with the native version now provided by the MCP server.Details
0.18.1.type_textimplementation and related declarative tool classes.type_text.Related Issues
Closes #20983
How to Validate
npm test -w @google/gemini-cli-core -- src/agents/browsertype_textis correctly discovered from the MCP server.Pre-Merge Checklist