Conversation
|
Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the user experience when confirming shell command executions within the CLI. It introduces syntax highlighting and proper multiline formatting for shell commands displayed in tool confirmation messages, making them easier to read and understand. This enhancement is supported by new and updated snapshot tests to ensure visual consistency and correctness across various display scenarios. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: -179 B (0%) Total Size: 26 MB ℹ️ View Unchanged
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces syntax highlighting for shell commands in the tool confirmation UI, which is a great improvement for readability. The implementation in ToolConfirmationMessage.tsx correctly uses the colorizeCode utility, and the new tests with SVG snapshots are a good addition to verify the visual changes.
However, I've noticed that several snapshot files (AskUserDialog.test.tsx.snap, ExitPlanModeDialog.test.tsx.snap, InputPrompt.test.tsx.snap) have snapshots removed, but their corresponding test files are not included in this PR. This is a significant concern as it might indicate that tests are no longer being properly asserted, and it goes against the repository's guideline to keep pull requests focused. These changes should either be reverted and moved to a separate PR if unrelated, or the corresponding test file changes should be included to provide context.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/cli/src/ui/components/snapshots/InputPrompt.test.tsx.snap (81-100)
This change removes multiple snapshots related to 'mouse interaction' tests, but the test file InputPrompt.test.tsx is not part of this PR. Deleting snapshots without modifying the tests that generate them is risky and makes the PR less focused.
Please revert these changes if they are not related to this PR, or provide the context from the test file.
References
- Pull requests should be small and focused. The changes to this snapshot file appear unrelated to the main purpose of this PR. (link)
gemini-cli
bot
added
area/core
There was a problem hiding this comment.
Intended to include this svg and the other one in this PR?
There was a problem hiding this comment.
yep. these svgs are verified with the snapshot tests.
2 participants
Summary
Fixes #21235
Large shell scripts are now readable
Syntax highlighting for shell scripts is ok but could be better with more advanced bash support.
Now that we highlight radio buttons using a consistent background color there is no risk of users mistaking the shell script content for a radio button. In addition the radio buttons are now consistently at the bottom of the window so are hard to confuse.