Skip to content

feat(cli): hide gemma settings from display and mark as experimental#21471

Merged
abhipatel12 merged 1 commit intomainfrom
abhi/gemma-settings-display
Mar 6, 2026
Merged

feat(cli): hide gemma settings from display and mark as experimental#21471
abhipatel12 merged 1 commit intomainfrom
abhi/gemma-settings-display

Conversation

@abhipatel12
Copy link
Copy Markdown
Contributor

Summary

Hides Gemma model router settings from the settings dialog and marks the enabled setting as experimental in its description.

Details

  • Sets showInDialog: false for experimental.gemmaModelRouter and experimental.gemmaModelRouter.enabled.
  • Updates the description for experimental.gemmaModelRouter.enabled to include "(experimental)".
  • Updates settings schema and documentation to reflect these changes.
  • Updates unit tests for the settings schema.

Related Issues

None.

How to Validate

  1. Run npm test -w @google/gemini-cli -- src/config/settingsSchema.test.ts and verify all tests pass.
  2. Check schemas/settings.schema.json and docs/reference/configuration.md to ensure they contain the updated descriptions.
  3. Verify that the Gemma settings no longer appear in the UI settings dialog (requires manual check in the CLI).

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run

@abhipatel12 abhipatel12 requested review from a team as code owners March 6, 2026 22:19
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the presentation of the experimental Gemma model router settings within the CLI. It ensures that these settings are no longer displayed in the user-facing settings dialogs and are clearly labeled as experimental in all relevant documentation and schema definitions, providing a cleaner and more accurate user experience for managing experimental features.

Highlights

  • UI Visibility: The Gemma model router settings are now hidden from the user interface dialogs by setting showInDialog to false.
  • Description Update: The description for the experimental.gemmaModelRouter.enabled setting has been updated to explicitly mark it as "(experimental)".
  • Documentation and Schema Alignment: Corresponding updates were made to the settings schema, documentation, and unit tests to reflect these visibility and description changes.
Changelog
  • docs/cli/settings.md
    • Removed the entry for the "Enable Gemma Model Router" from the CLI settings documentation.
  • docs/reference/configuration.md
    • Updated the description for experimental.gemmaModelRouter.enabled to include "(experimental)".
  • packages/cli/src/config/settingsSchema.test.ts
    • Updated unit tests to assert that gemmaModelRouter and gemmaModelRouter.enabled are not shown in the dialog.
    • Updated unit tests to assert that the enabled setting's description includes "(experimental)".
  • packages/cli/src/config/settingsSchema.ts
    • Modified the SETTINGS_SCHEMA to set showInDialog to false for both experimental.gemmaModelRouter and its enabled property.
    • Updated the description for the enabled property to include "(experimental)".
  • schemas/settings.schema.json
    • Updated the description and markdownDescription for experimental.gemmaModelRouter.enabled to include "(experimental)".
Activity
  • Relevant documentation and README were updated.
  • Tests were added/updated.
  • The changes were validated on MacOS.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2026

Size Change: +13 B (0%)

Total Size: 26 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 25.5 MB +13 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 221 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 227 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 11.5 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Mar 6, 2026
Copy link
Copy Markdown
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abhipatel12 abhipatel12 enabled auto-merge March 6, 2026 22:29
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request hides the experimental Gemma model router settings from the UI settings dialog. The changes involve setting showInDialog: false for the relevant settings in settingsSchema.ts. Correspondingly, the auto-generated documentation for the UI settings (docs/cli/settings.md) is updated to remove the setting, while the main configuration reference (docs/reference/configuration.md) is updated to mark the setting as experimental. The unit tests and the generated JSON schema are also updated to align with these changes. The implementation is consistent across all modified files.

@abhipatel12 abhipatel12 added this pull request to the merge queue Mar 6, 2026
Merged via the queue into main with commit 32e6152 Mar 6, 2026
29 of 30 checks passed
@abhipatel12 abhipatel12 deleted the abhi/gemma-settings-display branch March 6, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants