feat(cli): hide gemma settings from display and mark as experimental#21471
feat(cli): hide gemma settings from display and mark as experimental#21471abhipatel12 merged 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the presentation of the experimental Gemma model router settings within the CLI. It ensures that these settings are no longer displayed in the user-facing settings dialogs and are clearly labeled as experimental in all relevant documentation and schema definitions, providing a cleaner and more accurate user experience for managing experimental features. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: +13 B (0%) Total Size: 26 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request hides the experimental Gemma model router settings from the UI settings dialog. The changes involve setting showInDialog: false for the relevant settings in settingsSchema.ts. Correspondingly, the auto-generated documentation for the UI settings (docs/cli/settings.md) is updated to remove the setting, while the main configuration reference (docs/reference/configuration.md) is updated to mark the setting as experimental. The unit tests and the generated JSON schema are also updated to align with these changes. The implementation is consistent across all modified files.

Summary
Hides Gemma model router settings from the settings dialog and marks the enabled setting as experimental in its description.
Details
showInDialog: falseforexperimental.gemmaModelRouterandexperimental.gemmaModelRouter.enabled.experimental.gemmaModelRouter.enabledto include "(experimental)".Related Issues
None.
How to Validate
npm test -w @google/gemini-cli -- src/config/settingsSchema.test.tsand verify all tests pass.schemas/settings.schema.jsonanddocs/reference/configuration.mdto ensure they contain the updated descriptions.Pre-Merge Checklist