fix(core): use CLI version in IDE client connections#21582
fix(core): use CLI version in IDE client connections#21582Gyanranjan-Priyam wants to merge 1 commit intogoogle-gemini:mainfrom
Conversation
Resolves google-gemini#3487 - Import getVersion from utils/version.js - Replace hardcoded '1.0.0' with actual CLI version in HTTP connection - Replace hardcoded '1.0.0' with actual CLI version in stdio connection
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where IDE client connections were using a static, hardcoded version number instead of the actual CLI version. By integrating a dynamic version retrieval mechanism, the change ensures that all IDE client connections accurately report their current CLI version, improving consistency and providing more accurate diagnostic information. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly replaces a hardcoded version string '1.0.0' with a dynamic version lookup using getVersion() when establishing IDE client connections. The changes are applied to both HTTP and stdio connection methods. The implementation is straightforward and effectively ensures that the actual CLI version is reported to the IDE companion, fixing the described issue.
Gyanranjan-Priyam
left a comment
There was a problem hiding this comment.
I have successfully checked every things.
|
Hi there! Thank you for your interest in contributing to Gemini CLI. To ensure we maintain high code quality and focus on our prioritized roadmap, we have updated our contribution policy (see Discussion #17383). We only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. All other community pull requests are subject to closure after 14 days if they do not align with our current focus areas. For this reason, we strongly recommend that contributors only submit pull requests against issues explicitly labeled as 'help-wanted'. This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding and for being part of our community! |
Summary
Fixes #3487
Uses the actual CLI version instead of hardcoded
'1.0.0'in IDE client connections.Changes
getVersion()from../utils/version.jsestablishHttpConnection()establishStdioConnection()Testing
npm run preflight