feat(cli): add vim mode cursor shape setting#25347
Closed
chrisjcthomas wants to merge 3 commits intogoogle-gemini:mainfrom
Closed
feat(cli): add vim mode cursor shape setting#25347chrisjcthomas wants to merge 3 commits intogoogle-gemini:mainfrom
chrisjcthomas wants to merge 3 commits intogoogle-gemini:mainfrom
Conversation
- Document vi mode keyboard shortcuts in keyboard-shortcuts.md including navigation, editing, and mode switching commands - Add note that custom sandbox Dockerfile builds are only supported when running from source code (not via npm install) Closes google-gemini#17381, google-gemini#15141
18 tasks
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
The CLA check appears to be mismatched rather than unsigned. Evidence:
If a maintainer can rerun or refresh the CLA association for this PR, I’d appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in
general.vimModeCursorShapesetting that updates the terminal cursor shape to reflect Vim INSERT vs NORMAL mode.Details
useVimCursorShapehook that emits DECSCUSR cursor-shape sequences for INSERT and NORMAL modeVimModeProviderso it reacts to both mode transitions and live settings changesRelated Issues
Fixes #18390
How to Validate
npx vitest run packages/cli/src/ui/hooks/useVimCursorShape.test.ts packages/cli/src/config/settings-validation.test.ts packages/cli/src/config/settingsSchema.test.tsnpm run docs:settingsnpm run schema:settingsgeneral.vimModeandgeneral.vimModeCursorShape, then verify INSERT mode shows a bar cursor and NORMAL mode shows a block cursor.Pre-Merge Checklist