fix(core): honor GOOGLE_GEMINI_BASE_URL and GOOGLE_VERTEX_BASE_URL#25356
Closed
chrisjcthomas wants to merge 2 commits intogoogle-gemini:mainfrom
Closed
fix(core): honor GOOGLE_GEMINI_BASE_URL and GOOGLE_VERTEX_BASE_URL#25356chrisjcthomas wants to merge 2 commits intogoogle-gemini:mainfrom
chrisjcthomas wants to merge 2 commits intogoogle-gemini:mainfrom
Conversation
- Document vi mode keyboard shortcuts in keyboard-shortcuts.md including navigation, editing, and mode switching commands - Add note that custom sandbox Dockerfile builds are only supported when running from source code (not via npm install) Closes google-gemini#17381, google-gemini#15141
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
Recreated on #25357 using a neutral branch name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15430
Summary
This change wires custom base URL overrides through the core content generator so they are passed to
@google/genaiviahttpOptions.baseUrl.What Changed
baseUrltoContentGeneratorConfigGOOGLE_GEMINI_BASE_URLforAuthType.USE_GEMINIGOOGLE_VERTEX_BASE_URLforAuthType.USE_VERTEX_AIbaseUrlintoGoogleGenAIthroughhttpOptionsWhy
The Gemini CLI uses
@google/genai, which supports a custom base URL viahttpOptions.baseUrl. Before this change, the CLI propagated the environment variables but did not apply them when instantiating the SDK client.Validation
npm test -- src/core/contentGenerator.test.tsnpm run typecheckNotes
import/no-internal-modulesrather than this patch.