fix(patch): cherry-pick 048bf6e to release/v0.40.0-preview.3-pr-25941 to patch version v0.40.0-preview.3 and create version 0.40.0-preview.4#25942
Conversation
|
Size Change: -214 B (0%) Total Size: 33.7 MB
ℹ️ View Unchanged
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the handling of backspace characters within the CLI's keypress context. By removing conditional logic that previously differentiated between operating systems and terminal sessions, the application now treats backspace inputs consistently across environments. This change simplifies the codebase and ensures more predictable behavior for terminal input processing. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies backspace handling by treating both \b and \x7f as standard backspace and removing platform-specific logic for Windows Terminal. It also updates related test constants and removes obsolete test cases. A review comment identifies that several Vitest functions are still used in KeypressContext.test.tsx despite being removed from the imports, which needs to be corrected to prevent test failures.
| beforeEach, | ||
| afterEach, | ||
| } from 'vitest'; | ||
| import { vi, afterAll, beforeAll, type Mock } from 'vitest'; |
There was a problem hiding this comment.
The test file uses describe, it, expect, beforeEach, and afterEach, but these are no longer imported from vitest. This will cause the tests to fail if globals are not enabled, and it is inconsistent with other test files in the repository which explicitly import these functions.
| import { vi, afterAll, beforeAll, type Mock } from 'vitest'; | |
| import { | |
| vi, | |
| afterAll, | |
| beforeAll, | |
| describe, | |
| it, | |
| expect, | |
| beforeEach, | |
| afterEach, | |
| type Mock, | |
| } from 'vitest'; |
gemini-cli
Bot
added
the
status/need-issue
scidomino
merged commit 31bdf11
into
release/v0.40.0-preview.3-pr-25941
scidomino
deleted the
hotfix/v0.40.0-preview.3/0.40.0-preview.4/preview/cherry-pick-048bf6e/pr-25941
branch
2 participants
This PR automatically cherry-picks commit 048bf6e to patch version v0.40.0-preview.3 in the preview release to create version 0.40.0-preview.4.