Skip to content

Allow non-https proxy urls to support container environments#26234

Merged
scidomino merged 6 commits intogoogle-gemini:mainfrom
stevemk14ebr:main
Apr 29, 2026
Merged

Allow non-https proxy urls to support container environments#26234
scidomino merged 6 commits intogoogle-gemini:mainfrom
stevemk14ebr:main

Conversation

@stevemk14ebr
Copy link
Copy Markdown
Contributor

Summary

Reverts new restriction that auth urls require https on non-localhost. This prior change breaks valid enterprise auth proxy configurations in container environments, and is now fixed. See #25357 (comment)

Related Issues

A prior change like this was done in #23976 but re-added recently in #25357

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@stevemk14ebr stevemk14ebr requested a review from a team as a code owner April 29, 2026 22:34
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request removes a restrictive validation check that required HTTPS for custom base URLs unless they were pointing to localhost. This change is intended to support enterprise auth proxy configurations commonly found in containerized environments, ensuring that valid non-HTTPS proxy setups are no longer blocked by the client.

Highlights

  • Removed HTTPS restriction: Removed the validation logic that enforced HTTPS for non-localhost custom base URLs, allowing for more flexible proxy configurations.
  • Updated test suite: Updated the unit tests to reflect the removal of the HTTPS requirement and added a test case specifically for container-internal hostnames.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@scidomino scidomino enabled auto-merge April 29, 2026 22:34
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the requirement for custom base URLs to use HTTPS, enabling support for non-secure container-internal addresses. While the validation logic was removed, the corresponding test case was updated in name only and still asserts a rejection, which will cause the test suite to fail.

Comment thread packages/core/src/core/contentGenerator.test.ts Outdated
auto-merge was automatically disabled April 29, 2026 22:36

Head branch was pushed to by a user without write access

@gemini-cli gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label Apr 29, 2026
@scidomino scidomino enabled auto-merge April 29, 2026 22:47
@scidomino scidomino added this pull request to the merge queue Apr 29, 2026
Merged via the queue into google-gemini:main with commit a2d10b7 Apr 29, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants