Allow non-https proxy urls to support container environments#26234
Allow non-https proxy urls to support container environments#26234scidomino merged 6 commits intogoogle-gemini:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request removes a restrictive validation check that required HTTPS for custom base URLs unless they were pointing to localhost. This change is intended to support enterprise auth proxy configurations commonly found in containerized environments, ensuring that valid non-HTTPS proxy setups are no longer blocked by the client. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the requirement for custom base URLs to use HTTPS, enabling support for non-secure container-internal addresses. While the validation logic was removed, the corresponding test case was updated in name only and still asserts a rejection, which will cause the test suite to fail.
Head branch was pushed to by a user without write access
Summary
Reverts new restriction that auth urls require https on non-localhost. This prior change breaks valid enterprise auth proxy configurations in container environments, and is now fixed. See #25357 (comment)
Related Issues
A prior change like this was done in #23976 but re-added recently in #25357
Pre-Merge Checklist