Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @chrstnb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new, dedicated UI drawer within the IDE mode of the CLI application. This drawer allows users to quickly view their active and recently opened files, enhancing the overall user experience by providing immediate and easily accessible file context.
Highlights
- New IDE Context Drawer: A dedicated UI component (
IDEContextDetailDisplay) has been added to display details about active and recently opened files when the application is in IDE mode. This drawer provides a clear overview of the current file context. - Keyboard Shortcut for Context Toggle: Users can now toggle the visibility of the new IDE context drawer using the
Ctrl+Ekeyboard shortcut, providing quick access to file context information. - Updated Context Summary Display: The existing
ContextSummaryDisplayhas been updated to provide a more concise summary of open files, indicating the number of recent files and hinting at the newCtrl+Eshortcut for detailed context.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a new drawer component to display active and recent files from the IDE, which can be toggled with ctrl+e. The implementation is mostly solid, but I've identified a few issues. There's a logic error in the context summary display that could hide information about the active file from the user. Additionally, the new IDEContextDetailDisplay component has a condition that could lead to rendering an empty container, and it uses an index as a React key, which is an anti-pattern. My review includes suggestions to fix these issues.
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x' artifact from the main CI run. |
skeshive
left a comment
There was a problem hiding this comment.
LGTM overall , just 2 small comments
- please address /gemini review comments, they seem relevant
- in the summary, we show "6 recent files" but the detailed view shows 7 files (including the active files), can you account for this?
all addressed! thanks @skeshive |
|
Thanks for the update, @chrstnb! It's great to hear that the review comments have been addressed. Please let me know if you'd like me to perform another review of the changes. |
NTaylorMullen
left a comment
There was a problem hiding this comment.
Approving to unblock BUT one thing to think about is how do you plan to represent additional context such as "errors" when we start absorbing those? I imagine there will be UX implications to consider where we may go from # VSCode files => # VSCode context or something of the like
Co-authored-by: Shreya <shreyakeshive@google.com>
Co-authored-by: Shreya <shreyakeshive@google.com>
Co-authored-by: Shreya <shreyakeshive@google.com>
Co-authored-by: Shreya <shreyakeshive@google.com>
Co-authored-by: Shreya <shreyakeshive@google.com>
TLDR
Add a separate drawer for IDE context invoked with ctrl+e
Dive Deeper
I'm not wed to this approach, but it looks weird if we add this under the /mcp command (which is invoked via ctrl+t). This will only show up when the user is in IDE mode.
I like that it's sticky so it will follow you and show the active context while you're working, but open to alternative approaches.
Reviewer Test Plan
Screen.Recording.2025-07-22.at.3.48.33.PM.mov
Testing Matrix
Linked issues / bugs
#3907