Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @galz10, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is a critical revert that addresses build errors by rolling back the recent adoption of node-pty and xterm/headless. The core change involves reinstating Node.js's built-in child_process module for all shell command executions. This ensures the stability of builds across different environments, including g3 and the VSCode extension, which were negatively impacted by the previous changes. The PR also includes necessary adjustments to how shell output is processed, now distinguishing between standard output and standard error streams, and streamlines the tool scheduling by removing terminal size considerations.
Highlights
- Dependency Reversion: This PR reverts the previous integration of
@lydell/node-ptyand@xterm/headlesslibraries, which were causing build failures in certain environments (g3 and VSCode extension). - Shell Execution Mechanism: The shell execution mechanism has been switched back from
node-ptyto Node.js's nativechild_processmodule, ensuring broader compatibility. - Output Stream Handling: The code handling shell command output has been updated to correctly differentiate and process
stdoutandstderrstreams, which was a change necessitated by the switch back tochild_process. - API Simplification: References to terminal size parameters have been removed from shell execution and tool scheduling logic, simplifying the API and removing a dependency on terminal-specific properties.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Contributor
There was a problem hiding this comment.
Code Review
This pull request reverts the use of node-pty back to the standard child_process module to fix build errors. The changes are extensive, touching dependency management, build configuration, the core shell execution service, and numerous tests. The new implementation in shellExecutionService is robust, correctly handling platform-specific process termination and separate stdout/stderr streams. The associated tests have been updated effectively to cover these changes. The removal of node-pty also simplifies the output processing by replacing @xterm/headless with strip-ansi. Overall, the revert is well-executed and should resolve the critical build issues.
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
galz10
force-pushed
the
node-pty-revert
branch
from
56dc457 to
0d54a40
Compare
agarwalravikant
pushed a commit
to agarwalravikant/gemini-cli
that referenced
this pull request
Aug 18, 2025
acoliver
referenced
this pull request
in vybestack/llxprt-code
Aug 18, 2025
This is an empty merge commit to maintain parity with upstream structure. All changes have already been cherry-picked: - feat(shell): Include disallowed commands in block reason (#6278) - Fix license notice generation script (#6272) - IDE integration multi-folder support (#6265, #6177) - Show /ide enable & /ide disable commands (#6248) - Update versioning script (#6075) - Add eslint as recommended extension (#6196) - Add recommended extensions list (#5810) - Generate NOTICES.TXT and surface via command (#5310) - Stylize diff line numbers & characters (#6269) - Various other improvements and fixes Note: feat(core): refactor shell execution to use node-pty (#6088) was cherry-picked but later reverted upstream in #6328. We kept it as it works well with llxprt. Maintains llxprt's multi-provider support, branding, ServerToolsProvider, and authentication differences while staying in sync with upstream improvements.
JeongJaeSoon
pushed a commit
to JeongJaeSoon/gemini-cli
that referenced
this pull request
Aug 21, 2025
involvex
pushed a commit
to involvex/gemini-cli
that referenced
this pull request
Sep 11, 2025
reconsumeralization
pushed a commit
to reconsumeralization/gemini-cli
that referenced
this pull request
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting child-process to node-pty changes, causing build errors for g3 and vscode extension