Fix(command): line/block Comments Incorrectly Parsed as Slash Commands

[lifefloating]

TLDR

Fixed an issue where JavaScript comments starting with // were incorrectly parsed as slash commands, causing "Unknown command" errors and wrong UI coloring. The fix enhances the isSlashCommand function to properly distinguish between legitimate commands (/help) and code comments (//comment), ensuring comments are treated as normal text and sent directly to Gemini.

Key changes:

• Enhanced command recognition logic to exclude // and /* comments
• Updated UI components to use proper command detection
• Added comprehensive test coverage
• Fixed pink/purple UI coloring issue for comments

Dive Deeper

Root Cause Analysis

The issue occurred at multiple levels:

1. Command Recognition Logic: The isSlashCommand function used simple startsWith('/') check, which caught both legitimate commands (/help) and JavaScript comments (//comment)

2. UI Color Logic: Multiple UI components directly used text.startsWith('/') for styling decisions instead of using the proper isSlashCommand function

3. Processing Flow: All inputs starting with / were unconditionally passed to the slash command processor, even when they weren't actual commands

Problem Example

// check if variants base info all filled.
if(!objDetCtrl.variantInfo.baseInfo.title) {
    toastr.error('[Title] cannot be empty.')
    return false
}

This resulted in:

• ✗ "Unknown command" error
• ✗ Pink/purple UI coloring (command style)
• ✗ Input processed as potential command instead of normal text

Testing Matrix

	🍏	🪟	🐧
npm run	✅	❓	❓

Linked issues / bugs

#6953
#2240

[gemini-code-assist]

Summary of Changes

Hello @lifefloating, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug where JavaScript and C-style comments were mistakenly parsed as slash commands within the CLI, leading to "Unknown command" errors and incorrect UI coloring. The core of the fix involves refining the isSlashCommand utility function to accurately distinguish between actual commands and code comments. This improved logic is then consistently applied across various UI components and the command processing flow, ensuring that comments are treated as normal text and the UI reflects the correct state.

Highlights

• Command Recognition Logic: The isSlashCommand utility function has been updated to correctly differentiate between legitimate slash commands (e.g., /help) and code comments (e.g., // comment or /* comment */). It now explicitly excludes strings starting with // or /*.
• UI Component Updates: UI components like SuggestionsDisplay.tsx and UserMessage.tsx that previously used text.startsWith('/') for styling and command mode detection now correctly utilize the enhanced isSlashCommand utility function. This resolves the incorrect pink/purple coloring for comments.
• Command Processing Flow: The useGeminiStream hook now only attempts to process a query as a slash command if isSlashCommand returns true, preventing comments from being sent to the slash command processor.
• Test Coverage: New test cases have been added to useCommandCompletion.test.ts, useGeminiStream.test.tsx, and commandUtils.test.ts to ensure that JavaScript and C-style comments are correctly identified as non-commands and do not trigger command-related behaviors or prompt completions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively resolves the issue of JavaScript and C-style comments being misinterpreted as slash commands. The approach of centralizing the logic in the isSlashCommand utility function and updating all call sites is clean and correct. The addition of comprehensive unit tests for both the utility function and its usage in various hooks is excellent. I have one suggestion to make the new isSlashCommand function more concise and maintainable, but overall this is a solid contribution.

[lifefloating]

Examples:

Before:

After:

The test code examples in the related issue can also pass.

[abhipatel12]

Hey! Thanks for the contribution! Left a few comments. Lmk what you think and then I can approve!

[lifefloating]

Hi @abhipatel12
Thanks for the thoughtful review feedback!

You're absolutely right that comments such as these are not limited to C++/JavaScript.
The generic terminology "line comments" and "block comments" is much more appropriate and language-agnostic.

[abhipatel12]

Looks great, thanks for making the changes!

LGTM, I'll get this set up for final approval and merged. Thanks again for the contribution.