fix(logging): Log NodeJS Version && Make Config.SessionID readonly#7219
Merged
richieforeman merged 2 commits intomainfrom Aug 28, 2025
Merged
fix(logging): Log NodeJS Version && Make Config.SessionID readonly#7219richieforeman merged 2 commits intomainfrom
richieforeman merged 2 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @richieforeman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the robustness of the application's configuration and enhancing its telemetry capabilities. It ensures that the session ID, a critical identifier, remains constant throughout the application's lifecycle by making it read-only. Concurrently, it augments the logging system to automatically capture the NodeJS version, providing richer environmental data for analysis and debugging purposes.
Highlights
- Configuration Immutability: The
sessionIdproperty within theConfigclass has been madereadonly, ensuring that its value can only be assigned once during object construction and cannot be modified thereafter. This change aligns with the intended usage of the session ID as a constant identifier for the execution. - Enhanced Telemetry Logging: The telemetry system has been enhanced to automatically log the current NodeJS version alongside other system information. This provides valuable context for debugging and understanding the environment in which the application is running.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces two main improvements: it adds the NodeJS version to the telemetry logs and makes the Config.SessionId property readonly, enhancing immutability. The changes are well-implemented and include a corresponding test for the new logging feature. My only feedback is a suggestion to improve the maintainability of the EventMetadataKey enum to avoid potential confusion with manually assigned numeric values.
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
thacio
added a commit
to thacio/auditaria
that referenced
this pull request
Aug 28, 2025
…ig.SessionID readonly (google-gemini#7219)
bl-ue
added a commit
to Piebald-AI/gemini-cli
that referenced
this pull request
Aug 29, 2025
It was made mutable in google-gemini#5221 as part of this google-gemini#4401 branch, but that was too early, and so was reverted in google-gemini#7219. We need it mutable as part of the setup but we'll not bring it to main until it's needed.
davideast
pushed a commit
to davideast/gemini-cli
that referenced
this pull request
Sep 2, 2025
reconsumeralization
pushed a commit
to reconsumeralization/gemini-cli
that referenced
this pull request
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Dive Deeper
Reviewer Test Plan
Testing Matrix
Linked issues / bugs
Resolves #65