Skip to content

feat(core): Enable ripgrep by default.#7427

Merged
joshualitt merged 2 commits intogoogle-gemini:mainfrom
joshualitt:enable-ripgrep
Sep 12, 2025
Merged

feat(core): Enable ripgrep by default.#7427
joshualitt merged 2 commits intogoogle-gemini:mainfrom
joshualitt:enable-ripgrep

Conversation

@joshualitt
Copy link
Copy Markdown
Contributor

TLDR

Enables ripgrep by default

Testing Matrix

🍏 🪟 🐧
npm run ✔️
npx
Docker
Podman - -
Seatbelt - -

Linked issues / bugs

@gemini-cli gemini-cli bot added kind/enhancement priority/p2 Important but can be addressed in a future release. labels Aug 29, 2025
@joshualitt joshualitt force-pushed the enable-ripgrep branch 13 times, most recently from 07b6eaf to 859ad21 Compare September 9, 2025 20:31
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure why, but for some reason I had to disable ripgrep here and in the below test to get the subagent tests to pass on windows, otherwise they were mysteriously timing out. I can investigate more if desired, but it may just be a timers issue.

@joshualitt joshualitt requested a review from jacob314 September 9, 2025 20:54
@joshualitt
Copy link
Copy Markdown
Contributor Author

Sending out for early review, still need to test more on windows.

@joshualitt joshualitt marked this pull request as ready for review September 9, 2025 21:57
@joshualitt joshualitt requested a review from a team as a code owner September 9, 2025 21:57
Copy link
Copy Markdown
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gemini-cli gemini-cli bot added status/in-progress and removed priority/p2 Important but can be addressed in a future release. labels Sep 10, 2025
@joshualitt joshualitt added this pull request to the merge queue Sep 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2025
@joshualitt joshualitt added this pull request to the merge queue Sep 11, 2025
Merged via the queue into google-gemini:main with commit 6803559 Sep 12, 2025
24 checks passed
@joshualitt joshualitt deleted the enable-ripgrep branch September 12, 2025 00:00
giraffe-tree pushed a commit to giraffe-tree/gemini-cli that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Turn on ripgrep by default

2 participants