Merged
Conversation
|
Size Change: +10.7 kB (+0.09%) Total Size: 12.5 MB
ℹ️ View Unchanged
|
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
jacob314
reviewed
Sep 5, 2025
Contributor
jacob314
left a comment
There was a problem hiding this comment.
Looks good. Please add tests verifying that hidden commands are actually hidden
This commit introduces tests to verify that slash commands with the `hidden` property are properly filtered out and not displayed to the user. - The core filtering logic is now centralized in `CommandService` to ensure that hidden commands are excluded from all parts of the application. - Unit tests have been added for `CommandService` and `slashCommandProcessor` to validate this behavior. - Redundant filtering logic has been removed from the `Help` and `useSlashCompletion` UI components. - Additionally, this commit fixes a pre-existing, unrelated test failure in `contentGenerator.test.ts` that was caused by an environment variable leak between tests.
Collaborator
Author
Thanks @jacob314! Tests added. PTAL. Note that the same three E2E tests are failing, but those appear unrelated. |
Contributor
|
The 1 pr ahead of you in the merge queue will fix the failing tests. |
giraffe-tree
pushed a commit
to giraffe-tree/gemini-cli
that referenced
this pull request
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TLDR
Allow for slash commands to opt-out of autocompletion and /help discovery.
Dive Deeper
As slash commands become more numerous allow for a command to opt out if it's unnecessary to advertise them on a case-by-case basis.
Reviewer Test Plan
Type / and see if hidden slash commands are auto-completed.
Enter /help and see if hidden slash commands are included.
Testing Matrix
Linked issues / bugs
Fixes #7796