Merged
Conversation
This commit enhances the user experience in the theme selection dialog by preserving the user's highlighted choice when they tab between the theme list and the scope selector. Specifically, the following changes were made: - The `ThemeDialog` now initializes the theme list with the last highlighted theme, preventing the selection from resetting to the saved theme. - The `ScopeSelector` now accepts an `initialScope` prop, allowing it to be initialized with the user's previous selection. - The `ThemeDialog` passes the currently selected scope to the `ScopeSelector` to maintain its state across tabs.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @miguelsolorio, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors the user interface for theme selection by extracting the scope settings into a dedicated dialog. This change aims to optimize screen real estate within the existing theme dialog, providing a cleaner and more focused user experience for theme selection, while allowing for a more robust scope configuration.
Highlights
- Dedicated Scope Selection Dialog: Introduced a new, reusable ScopeSelector component to handle the selection of setting scopes (user, workspace, system).
- Improved Theme Dialog Layout: The ThemeDialog has been refactored to offload the scope selection UI to the new dialog, making more space for theme-related content.
- Enhanced User Experience: Users can now tab between selecting a theme and configuring its scope in a separate, dedicated view, improving navigation and clarity.
- Modular UI Component: The ScopeSelector is designed for reusability, with plans to integrate it into other settings dialogs in the future.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Size Change: -353 B (0%) Total Size: 12.5 MB ℹ️ View Unchanged
|
gemini-cli
bot
added
kind/enhancement
priority/p1
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully refactors the scope selection logic out of the ThemeDialog and into a new, reusable ScopeSelector component. This is a great improvement for modularity and simplifies the ThemeDialog component significantly. The new interaction flow for selecting themes and scopes is clear. I have one suggestion to improve performance by memoizing a callback passed to a hook.
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
jacob314
reviewed
Sep 7, 2025
Contributor
jacob314
left a comment
jacob314
left a comment
There was a problem hiding this comment.
please ask Gemini CLI to add a text snapshot test for ThemeDialog using the same mechanism used for other golden snapshot tests in @packages/cli.
Add a snapshot both when toggled in scope selector mode and when not.
Contributor
Author
|
@jacob314 ✅ updated |
SandyTao520
pushed a commit
that referenced
this pull request
Sep 10, 2025
giraffe-tree
pushed a commit
to giraffe-tree/gemini-cli
that referenced
this pull request
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
This moves out the scope settings into a new dialog to make more space for the existing content.
Dive Deeper
Reviewer Test Plan
Testing Matrix
Linked issues / bugs