Skip to content

Fix ctrl-c/esc while Authenticating. #7879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdmorgan merged 1 commit into from
Sep 6, 2025
Merged

Fix ctrl-c/esc while Authenticating. #7879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/cli/src/ui/AppContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,7 +903,6 @@ Logging in with Google... Please restart Gemini CLI to continue.
isEditorDialogOpen ||
isSettingsDialogOpen ||
isFolderTrustDialogOpen ||
isAuthenticating ||
showPrivacyNotice;
if (anyDialogOpen) {
return;
Expand Down Expand Up @@ -932,9 +931,6 @@ Logging in with Google... Please restart Gemini CLI to continue.
) {
handleSlashCommand('/ide status');
} else if (keyMatchers[Command.QUIT](key)) {
if (isAuthenticating) {
return;
}
if (!ctrlCPressedOnce) {
cancelOngoingRequest?.();
}
Expand Down Expand Up @@ -968,7 +964,6 @@ Logging in with Google... Please restart Gemini CLI to continue.
setCtrlDPressedOnce,
ctrlDTimerRef,
handleSlashCommand,
isAuthenticating,
cancelOngoingRequest,
isThemeDialogOpen,
isAuthDialogOpen,
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/ui/components/DialogManager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export const DialogManager = () => {
return (
<AuthInProgress
onTimeout={() => {
/* This is now handled in AppContainer */
uiActions.onAuthError('Authentication cancelled.');
}}
/>
);
Expand Down
Loading