Skip to content

fix(ui): disable input prompt during tool confirmation #7935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacob314 merged 2 commits into from
Sep 7, 2025
Merged

fix(ui): disable input prompt during tool confirmation #7935

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
536756a
fix(ui): disable input prompt during tool confirmation
Lyonk71 Sep 7, 2025
57f6daf
Merge branch 'main' into fix/7912-disable-input-tool-messages
jacob314 Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions packages/cli/src/ui/AppContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
type HistoryItemWithoutId,
AuthState,
} from './types.js';
import { MessageType } from './types.js';
import { MessageType, StreamingState } from './types.js';
import {
type EditorType,
type Config,
Expand Down Expand Up @@ -699,7 +699,20 @@ Logging in with Google... Please restart Gemini CLI to continue.

const { handleInput: vimHandleInput } = useVim(buffer, handleFinalSubmit);

const isInputActive = !initError && !isProcessing;
/**
* Determines if the input prompt should be active and accept user input.
* Input is disabled during:
* - Initialization errors
* - Slash command processing
* - Tool confirmations (WaitingForConfirmation state)
* - Any future streaming states not explicitly allowed
*/
const isInputActive =
!initError &&
!isProcessing &&
(streamingState === StreamingState.Idle ||
streamingState === StreamingState.Responding) &&
!isProQuotaDialogOpen;

// Compute available terminal height based on controls measurement
const availableTerminalHeight = useMemo(() => {
Expand Down
Loading