fix(trust): Pass folderTrust config to a2a server#8082
Merged
richieforeman merged 3 commits intomainfrom Sep 11, 2025
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @shishu314, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue where the folderTrust configuration was not being correctly propagated to the a2a server. By introducing this setting into the server's configuration and utilizing it in relevant operations, the PR ensures that the server operates with the appropriate security context regarding folder trust, enhancing the overall security posture and configurability of the system.
Highlights
- Configuration Update: The folderTrust setting is now properly passed from the client to the a2a server, ensuring that file operations respect the configured trust level.
- Code Refinement: Replaced a hardcoded true value with the dynamic folderTrust setting in a function call within config.ts, making the server's behavior configurable.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly passes the folderTrust configuration to the a2a server. However, I've identified a critical security vulnerability related to how the folderTrust setting is processed. Since the setting comes from a JSON file without runtime type validation, using the nullish coalescing operator (??) can lead to non-boolean truthy values (like the string "false") being treated as true, which would bypass the folder trust security control. My review includes suggestions to fix this by using a strict equality check to ensure the value is explicitly the boolean true.
|
Size Change: -2 B (0%) Total Size: 13.2 MB ℹ️ View Unchanged
|
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
richieforeman
approved these changes
Sep 11, 2025
Member
richieforeman
left a comment
richieforeman
left a comment
There was a problem hiding this comment.
LG, tagging @cornmander for final
giraffe-tree
pushed a commit
to giraffe-tree/gemini-cli
that referenced
this pull request
Oct 10, 2025
Co-authored-by: Shi Shu <shii@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Pass the folderTrust setting from the a2a server
Dive Deeper
N/A
Reviewer Test Plan
logger.infointo the a2a-server code to check the values passednpm run buildandnpm run start:a2a-server"geminicodeassist.a2a.address": "http://localhost:41242/"Testing Matrix
Linked issues / bugs
Fixes https://github.com/google-gemini/maintainers-gemini-cli/issues/729