Skip to content

feat(core): Copy downloadRipGrep with license.#8195

Merged
joshualitt merged 1 commit intogoogle-gemini:mainfrom
joshualitt:copy-code
Sep 11, 2025
Merged

feat(core): Copy downloadRipGrep with license.#8195
joshualitt merged 1 commit intogoogle-gemini:mainfrom
joshualitt:copy-code

Conversation

@joshualitt
Copy link
Copy Markdown
Contributor

TLDR

Copies downloadRipGrep into the repo along with its license.

Dive Deeper

This CL just copies the code. In the follow-up, we can add tests and wire this code up.

Testing Matrix

🍏 🪟 🐧
npm run ✔️
npx
Docker
Podman - -
Seatbelt - -

Linked issues / bugs

Necessary for #7327

@gemini-cli gemini-cli bot added kind/enhancement priority/p2 Important but can be addressed in a future release. labels Sep 10, 2025
@joshualitt joshualitt marked this pull request as ready for review September 10, 2025 16:30
@joshualitt joshualitt requested a review from a team as a code owner September 10, 2025 16:30
@gemini-cli gemini-cli bot removed the priority/p2 Important but can be addressed in a future release. label Sep 11, 2025
@joshualitt
Copy link
Copy Markdown
Contributor Author

@teeler , @jacob314 ptal. I've gotten confirmation that the top level third_party directory + license file in subdirectory is the way to go.

Copy link
Copy Markdown
Contributor

@teeler teeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@joshualitt joshualitt added this pull request to the merge queue Sep 11, 2025
Merged via the queue into google-gemini:main with commit 59182a9 Sep 11, 2025
40 of 41 checks passed
@joshualitt joshualitt deleted the copy-code branch September 11, 2025 20:25
giraffe-tree pushed a commit to giraffe-tree/gemini-cli that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants