fix(core): Default skipNextSpeakerCheck to true when the setting is not manually set#8295
Merged
SandyTao520 merged 1 commit intomainfrom Sep 11, 2025
Merged
fix(core): Default skipNextSpeakerCheck to true when the setting is not manually set#8295SandyTao520 merged 1 commit intomainfrom
SandyTao520 merged 1 commit intomainfrom
Conversation
|
Size Change: -3 B (0%) Total Size: 13.2 MB ℹ️ View Unchanged
|
galz10
approved these changes
Sep 11, 2025
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
giraffe-tree
pushed a commit
to giraffe-tree/gemini-cli
that referenced
this pull request
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Quick fix for when the setting is not explicitly set in setting.json, we're not picking up default from settingsSchema. Need to set this to true here to make sure it is true. Real fix in #8045.
Testing Matrix