feat: ensure cred file is created with a predictable name #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethvargo
force-pushed
the
sethvargo/predictable_path
branch
from
e1e7b58 to
5323b36
Compare
bharathkkb
reviewed
Feb 3, 2022
Contributor
bharathkkb
left a comment
bharathkkb
left a comment
There was a problem hiding this comment.
LGTM and not related to this change but from the logs it looks like we were not building the action in CI and using the older distributable
auth/.github/workflows/test.yml
Lines 53 to 61 in 3b7fb59
sethvargo
force-pushed
the
sethvargo/predictable_path
branch
from
5323b36 to
975c0f3
Compare
Contributor
Author
|
@bharathkkb fixed the |
bharathkkb
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123