Skip to content

Revert "Use RUNNER_TEMP to export credentials" #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sethvargo merged 2 commits into from
Jul 22, 2020
Merged

Revert "Use RUNNER_TEMP to export credentials" #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27b86f0
Revert "Use RUNNER_TEMP to export credentials (#148)"
sethvargo Jul 22, 2020
149247d
Update README.md
sethvargo Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions package-lock.json
View file
Open in desktop

This file was deleted.

7 changes: 3 additions & 4 deletions setup-gcloud/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,9 @@ It does the following:

**IMPORTANT!** Exporting default credentials requires `actions/checkout@v2`.
The `v1` tag is not supported and will not work.

**WARNING!** This persists the credentials to a temporary path on disk. If
you are building packages, ensure you do **not** use `RUNNER_TEMP` or you
risk including the service account credential in your build.

**WARNING!** This persists the application credentials inside the workspace. If
you are building packages or artifacts, be sure to exclude the credentials!

## Prerequisites

Expand Down
Loading