Skip to content

Fix broken README links #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sethvargo merged 1 commit into from
Nov 30, 2021
Merged

Fix broken README links #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example-workflows/cloud-run/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ For pushes to the `example` branch, this workflow will:

1. [Enable the Cloud Run API](https://console.cloud.google.com/flows/enableapi?apiid=run.googleapis.com).

1. [Create a Google Cloud service account][sa] or select an existing one.
1. [Create a Google Cloud service account][create-sa] or select an existing one.

1. Add the the following [Cloud IAM roles][roles] to your service account:

Expand Down
3 changes: 2 additions & 1 deletion example-workflows/gae/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ For pushes to the `example` branch, this workflow will:

1. [Initialize your App Engine app with your project](https://cloud.google.com/appengine/docs/standard/nodejs/console#console).

1. [Create a Google Cloud service account][sa] or select an existing one.
1. [Create a Google Cloud service account][create-sa] or select an existing one.

1. Add the the following [Cloud IAM roles][roles] to your service account:

Expand All @@ -43,5 +43,6 @@ For pushes to the `example` branch, this workflow will:

- `GCP_SA_KEY`: the downloaded service account key

[create-sa]: https://cloud.google.com/iam/docs/creating-managing-service-accounts
[secrets]: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/creating-and-using-encrypted-secrets
[roles]: https://cloud.google.com/iam/docs/granting-roles-to-service-accounts#granting_access_to_a_service_account_for_a_resource