Skip to content

Set buttonStyle to be MainActor #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
w-goog merged 2 commits into from
Aug 20, 2025
Merged

Set buttonStyle to be MainActor #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f62368
set buttonStyle to be MainActor
camden-king Aug 8, 2025
0bcd855
add @MainActor to GoogleSignInButtonStylingTests
camden-king Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions GoogleSignInSwift/Sources/GoogleSignInButtonViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ public class GoogleSignInButtonViewModel: ObservableObject {

/// A computed property providing the button's size, colors, corner radius,
/// and shadow based on this current view model's `SignInButtonStyle`.
@MainActor
var buttonStyle: SwiftUIButtonStyle {
return SwiftUIButtonStyle(style: style, state: state, scheme: scheme)
}
Expand Down
1 change: 1 addition & 0 deletions GoogleSignInSwift/Tests/Unit/GoogleSignInButtonStylingTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import XCTest
@testable import GoogleSignInSwift

@MainActor
@available(iOS 13.0, macOS 10.15, *)
class GoogleSignInButtonStylingTests: XCTestCase {
private typealias ButtonViewModelInfo = (
Expand Down