Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Conversation

@mkobit
Copy link

@mkobit mkobit commented Jun 23, 2017

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot
Copy link

CLAs look good, thanks!

When attempting to execute the built `moe` binary after running `make-binary.sh` it exits with an exception.
It exits with a `Caused by: java.lang.ClassNotFoundException: com.google.auto.factory.internal.Preconditions`.
This removes the snapshot dependencies from the projecgt and the snapshots repository.
@Yannic
Copy link

Yannic commented Jun 28, 2017

Also see #39

@mkobit
Copy link
Author

mkobit commented Jun 30, 2017

@Yannic nice call - I tried executing it after and also saw issues with using internal classes for AutoValue

@mkobit mkobit mentioned this pull request Jun 30, 2017
jamierocks pushed a commit to revision-notes/MOE that referenced this pull request Sep 15, 2017
Remove other snapshot dependencies in `auto-value` and `auto-factory`

When attempting to execute the built `moe` binary after running `make-binary.sh` it exits with an exception.
It exits with a `Caused by: java.lang.ClassNotFoundException: com.google.auto.factory.internal.Preconditions`.
This removes the snapshot dependencies from the projecgt and the snapshots repository.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants