feat: Add enum constraint to agent_name for transfer_to_agent#2437
Closed
qieqieplus wants to merge 1 commit intogoogle:mainfrom
Closed
feat: Add enum constraint to agent_name for transfer_to_agent#2437qieqieplus wants to merge 1 commit intogoogle:mainfrom
agent_name for transfer_to_agent#2437qieqieplus wants to merge 1 commit intogoogle:mainfrom
Conversation
Collaborator
|
Response from ADK Triaging Agent Hello @qieqieplus, thank you for your contribution! To help us review this PR, could you please:
This information will help reviewers to review your PR more efficiently. Thanks! |
Collaborator
|
Could you resolve the conflicts so we can merge? |
Contributor
Author
Done. |
copybara-service Bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
Merge #2437 Current implementation of `transfer_to_agent` doesn't enforce strict constraints on agent names, we could use JSON Schema's enum definition to implement stricter constraints. Co-authored-by: Xuan Yang <xygoogle@google.com> COPYBARA_INTEGRATE_REVIEW=#2437 from qieqieplus:main 052e8e7 PiperOrigin-RevId: 836410397
Collaborator
|
Thank you @qieqieplus for your contribution! 🎉 Your changes have been successfully imported and merged via Copybara in commit 4a42d0d. Closing this PR as the changes are now in the main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation of
transfer_to_agentdoesn't enforce strict constraints on agent names,We could use JSON Schema's enum definition to implement stricter constraints:
Before
[{ "type": "function", "function": { "name": "transfer_to_agent", "description": "Transfer the question to another agent.\n\nThis tool hands off control to another agent when it's more suitable to answer the user's question according to the agent's description.\n\nArgs:\n agent_name: the agent name to transfer to.\n", "parameters": { "type": "object", "properties": { "agent_name": { "type": "string" } } } } }]After
[{ "type": "function", "function": { "name": "transfer_to_agent", "description": "Transfer the question to another agent.\n\nThis tool hands off control to another agent when it's more suitable to answer the user's question according to the agent's description.\n\nArgs:\n agent_name: the agent name to transfer to.\n", "parameters": { "type": "object", "properties": { "agent_name": { "type": "string", "enum": ["agent_a", "agent_b", "agent_c"] } } } } }]