Merged
Conversation
kocdemir
approved these changes
Aug 18, 2022
Collaborator
kocdemir
left a comment
kocdemir
left a comment
There was a problem hiding this comment.
lgtm, please submit after reviewing the commented change requests.
cmd/gapit/flags.go
Outdated
| Capture struct { | ||
| Frames int `help:"only capture the given number of frames. 0 for all"` | ||
| } | ||
| RespectAndroidFrameBoundary bool `help:"If true: respect the ANDROID_frame_boundary extension. If false: ignore."` |
Collaborator
There was a problem hiding this comment.
Can we rename this to IgnoreFrameBoundaryExtension and change the default value, hint text and behaviour accordingly?
gapii/client/capture.go
Outdated
| // WaitForDebugger makes gapii wait for a debugger to connect | ||
| WaitForDebugger Flags = 0x000000200 | ||
| // FLAG_RESPECT_ANDROID_FRAME_BOUNDARY | ||
| RespectFrameBoundaryDelimiters = 0x00001000 |
Collaborator
There was a problem hiding this comment.
Do we need 'Flags' suffix here ?
Contributor
Author
There was a problem hiding this comment.
Apparently not, but good catch. Added
rosasco-wk
pushed a commit
to rosasco-wk/agi
that referenced
this pull request
Sep 3, 2022
* Hide ANDROID_frame_boundary behind a flag / UI checkbox * Generalise the name of frame boundary delimiters * Change name "respect" to "ignore" and invert meaning * Change flag meaning to respect vkQueuePresent xor ANDROID_frame_boundary * fix presubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1168
This PR hides support for ANDROID_frame_boundary behind a flag, and exposes that flag as a checkbox in the Trace UI dialog