Remove shader debugging from Amber#1001
Merged
dneto0 merged 2 commits intogoogle:mainfrom Dec 8, 2022
Merged
Conversation
SwiftShader was the only implementation that supported this, but has disabled this code due to lack of use. If there's no driver that supports shader debugging, then it doesn't need to exist and be maintained in Amber. If one day, we want this again, then this CL can be reverted. Fixes: google#999
ben-clayton
force-pushed
the
issue-999
branch
from
ef188af to
0a96d39
Compare
About "detected dubious ownership"
ben-clayton
force-pushed
the
issue-999
branch
from
0a96d39 to
d5b87d7
Compare
dneto0
approved these changes
Dec 8, 2022
Collaborator
dneto0
left a comment
dneto0
left a comment
There was a problem hiding this comment.
With regret, this is the right choice.
Thank you, this was/is amazing work.
| TOOLCHAIN_PATH="$ANDROID_NDK/build/cmake/android.toolchain.cmake" | ||
|
|
||
| # Disable git's "detected dubious ownership" error - kokoro checks out the repo with a different | ||
| # user, and we don't care about this warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SwiftShader was the only implementation that supported this, but has disabled this code due to lack of use. If there's no driver that supports shader debugging, then it doesn't need to exist and be maintained in Amber.
If one day, we want this again, then this CL can be reverted.
Fixes: #999