Support loading shaders from a FILE and as SPIRV-BIN#1056
Support loading shaders from a FILE and as SPIRV-BIN#1056nhaehnle wants to merge 2 commits intogoogle:mainfrom
Conversation
This is convenient in a number of cases. For example, one can more conveniently refer to a standalone shader source file. And one can pass-through a SPIR-V file that may be using a shader-only extension that Amber is unaware of.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| } | ||
|
|
||
| amber::Result LoadFile(const std::string, std::vector<char>&) const override { | ||
| return Result("DummyDelegate::LoadFile not implemented"); |
There was a problem hiding this comment.
| return Result("DummyDelegate::LoadFile not implemented"); | |
| return Result("PlaceholderDelegate::LoadFile not implemented"); |
There was a problem hiding this comment.
Are you sure? The class name is DummyDelegate.
There was a problem hiding this comment.
Oh, you're right. I'd thought I'd renamed that already. Leave this and I'll rename the delegate in the future.
|
Thank you for taking a look! I tried to address the check-format complaint. The license check complains that shader_spirv_bin.spv doesn't have a license. I suppose that's true, but given it's a binary file that may be difficult to satisfy. And while checking in binary files is obviously usually a bit questionable, it's in the nature of the test. Do you have any suggestions? |
|
Hm, I've been looking but can't find the documentation for license-check. I also don't have admin, and am unable to ignore the check. @dneto0 do you have the ability to ignore the failing required check and merge this regardless? (or do you know the magic to make license-checker skip the binary file?) |
|
ping @dneto0 |
I can't bypass the license checker. I'll do it in a new PR. |
They are SPIR-V binaries. This should allow google#1056 to land
They are SPIR-V binaries. This should allow #1056 to land
|
Landed as #1059 |
|
Thanks! |
4 participants
This is convenient in a number of cases. For example, one can more conveniently refer to a standalone shader source file. And one can pass-through a SPIR-V file that may be using a shader-only extension that Amber is unaware of.