Fixup acceleration structure and raytracing flags.#1073
Merged
dj2 merged 3 commits intogoogle:mainfrom Jan 7, 2025
Merged
Conversation
When determining if acceleration structures and ray tracing are supported it isn't enough to just check for the device extension. Both of these extensions maybe available, then the features contain a flag which determines if it is implemented. So, if we've got the features, we need to additionally check the flag and reset our internal tracking based on the implementation flag. Change-Id: I09b04007a47e5b5bec34c7ed910949401ca18a3b
dneto0
reviewed
Jan 7, 2025
dneto0
requested changes
Jan 7, 2025
Collaborator
dneto0
left a comment
dneto0
left a comment
There was a problem hiding this comment.
please update the comment.
Change-Id: If1710da425312603b5a793c67ca6afe8d9b467a9
Change-Id: I5ad8a5ea27ac79700a58c858da35681d3683765e
dneto0
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When determining if acceleration structures and ray tracing are supported it isn't enough to just check for the device extension. Both of these extensions maybe available, then the features contain a flag which determines if it is implemented. So, if we've got the features, we need to additionally check the flag and reset our internal tracking based on the implementation flag.
Change-Id: I09b04007a47e5b5bec34c7ed910949401ca18a3b