Group members of ConfigHelperVulkan.#1078
Merged
dj2 merged 2 commits intogoogle:mainfrom Jan 13, 2025
Merged
Conversation
Move the various members into separate structures to a) group them and b) make the names more distinct from other versions used in the helper. This adds a `vk_` group for all the vulkan objects, a `supports_` struct for all the booleans and a `features_` struct for all the feature objects.
Collaborator
Author
|
@gnl21 fyi, this is the change I suggested as maybe making things clearer. Does this seem a bit better? |
petermcneeleychromium
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the various members into separate structures to a) group them and b) make the names more distinct from other versions used in the helper.
This adds a
vk_group for all the vulkan objects, asupports_struct for all the booleans and afeatures_struct for all the feature objects.