Skip to content

Add Buffer::GetFormat#458

Merged
dneto0 merged 1 commit intogoogle:masterfrom
dj2:datum_02
Apr 10, 2019
Merged

Add Buffer::GetFormat#458
dneto0 merged 1 commit intogoogle:masterfrom
dj2:datum_02

Conversation

@dj2
Copy link
Collaborator

@dj2 dj2 commented Apr 10, 2019

This CL adds a GetFormat method directly to the Buffer class. The method
is overriden by the two sub-classes. The DataBuffer will cache the
generated format.

@dj2
Add Buffer::GetFormat
5eab44e 
This CL adds a GetFormat method directly to the Buffer class. The method
is overriden by the two sub-classes. The DataBuffer will cache the
generated format.
@dj2 dj2 added the refactoring Cleanup work label Apr 10, 2019
@dj2 dj2 requested review from dneto0 and hevrard April 10, 2019 14:11
@dj2 dj2 self-assigned this Apr 10, 2019
@dj2
Copy link
Collaborator Author

dj2 commented Apr 10, 2019

For context, this chain ends with only a single Buffer class. Data and Format buffers are merged ....

@dneto0 dneto0 merged commit d4e543b into google:master Apr 10, 2019
@dj2 dj2 deleted the datum_02 branch April 10, 2019 17:16
@dj2 dj2 mentioned this pull request Dec 9, 2019
Merged
dj2 added a commit that referenced this pull request Dec 9, 2019
@dj2
Rolling 12 dependencies (#746)
f231728 
Roll third_party/clspv/ 33d8fce7d..01bb48007 (2 commits)

google/clspv@33d8fce...01bb480

$ git log 33d8fce7d..01bb48007 --date=short --no-merges --format='%ad %ae %s'
2019-12-09 kpet Remove references to -S from the README (#458)
2019-12-06 alanbaker Improve image query generation (#456)

Roll third_party/clspv-llvm/ d96ea47c7..6626e5a06 (213 commits)

llvm/llvm-project@d96ea47...6626e5a

$ git log d96ea47c7..6626e5a06 --date=short --no-merges --format='%ad %ae %s'
2019-12-09 michael.hliao Fix compilation warning from GCC7. NFC.
2019-12-09 jh7370 [test][llvm-cxxfilt] Add missing '-n'
2019-12-09 zahira.ammarguellat Fix build bot fails due to the patch here: https://reviews.llvm.org/D70691 Fixed the LIT test case. Added the REQUIRES instruction.
2019-12-09 omair.javaid [lldb] Remove Xfail decorators from steadily passing tests
2019-12-09 jh7370 [test][llvm-cxxfilt] Fix darwin build bot
2019-11-21 sam.mccall [clangd] Allow extract-to-function on regions that always return.
2019-12-09 selliott [RISCV] Fix mir-target-flags.ll
2019-12-09 sam.mccall [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.
2019-12-09 selliott [RISCV] Machine Operand Flag Serialization
2019-12-05 djordje.todorovic [DebugInfo][EarlyCSE] Use the salvageDebugInfoOrMarkUndef(); NFC
2019-12-09 jeremy.morse [DebugInfo] Nerf placeDbgValues, with prejudice
2019-12-09 david.green [Attr] Add missing header for clang example.
2019-11-22 pavel [lldb/DWARF] Switch to llvm location list parser
2019-11-20 pavel [lldb] Improve/fix base address selection in location lists
2019-12-09 jh7370 [test][tools] Add missing and improve testing
2019-12-09 mikhail.maltsev [ARM][MVE] Add complex vector intrinsics
2019-12-09 david.green [ARM] Add missing REQUIRES: asserts to test. NFC
2019-12-09 omair.javaid [lldb] Xfail TestCallOverriddenMethod.py for aarch64/linux
2019-12-09 david.green [CommandLine] Add missing Callbacks
2019-12-08 david.green [ARM] Enable MVE masked loads and stores
2019-12-09 sam.mccall [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase
2019-12-09 sven.vanhaastregt [OpenCL] Handle address space conversions for constexpr (PR44177)
2019-12-09 llvmgnsyncbot gn build: Merge 6d5c273500a
2019-12-08 david.green [ARM] Teach the Arm cost model that a Shift can be folded into other instructions
2019-12-08 david.green [ARM] Additional tests and minor formatting. NFC
2019-12-06 hokein.wu Reland "[AST] Traverse the class type loc inside the member type loc.""
2019-11-29 pavel [cmake] Disable GCC 9's -Wredundant-move
2019-12-09 david.stenberg [DebugInfo] Make describeLoadedValue() reg aware
2019-12-09 teemperor [lldb] Support for DWARF-5 atomic types
2019-12-09 david.stenberg Revert "[DebugInfo] Make describeLoadedValue() reg aware"
2019-11-25 david.stenberg [DebugInfo] Make describeLoadedValue() reg aware
2019-12-03 calixte.denizet [compiler-rt] Add a critical section when flushing gcov counters
2019-12-09 teemperor [lldb] Add a test for how we lazily create Clang AST nodes
2019-12-09 hans Revert 393dacacf7e7 "[ARM] Enable TypePromotion by default"
2019-12-04 richard [c++20] Synthesis of defaulted comparison functions.
2019-12-09 zahira.ammarguellat Fix for build bot failure. For more details see: https://reviews.llvm.org/D70691 Upated LIT test.
2019-12-09 deadalnix [PowerPC] Automatically generate store-constant.ll . NFC
2019-12-08 thakis Fix a few doc typos, to cycle bots.
2019-12-08 jonas [lldb/SWIG] Guard embedded Python code in SWIG interfaces by SWIGPYTHON
2019-12-08 rollrat.cse [NFC][LivePhysRegs] Fix incorrect comment
2019-11-21 bryan.chan [Frontend] Allow OpenMP offloading to aarch64
2019-12-08 spatel [InstSimplify] fold copysign with negated operand, part 2
2019-12-08 sylvestre Fix typo in the AST Matcher Reference doc Closes: #54
2019-12-08 spatel [InstSimplify] fold copysign with negated operand
2019-12-08 dave Revert "Driver: Don't look for libc++ headers in the install directory on Android."
2019-11-19 kbessonova [llvm-dwarfdump][Statistics] Unify coverage statistic computation
2019-11-26 david.green [ARM] Attempt to use whole register vmovs for MVE shuffles.
2019-12-08 david.green [ARM] Disable VLD4 under MVE
2019-12-05 zeratul976 [clangd] Navigation from definition of template specialization to primary template
2019-12-07 flo [LV] Pick correct BB as insert point when fixing PHI for FORs.
(...)
2019-11-19 peter gn build: Bump Android API level to 29, and NDK to r21.
2019-12-05 craig.topper [X86] Make X86TargetLowering::BuildFILD return a std::pair of SDValues so we explicitly return the chain instead of calling getValue on the single SDValue.
2019-12-06 chen3.liu Add strict fp support for instructions fadd/fsub/fmul/fdiv
2019-12-06 llvmgnsyncbot gn build: Merge aeda128a96c
2019-12-06 llvmgnsyncbot gn build: Merge 6470497817e
2019-12-03 gclayton Add lookup functions for efficient lookups of addresses when using GsymReader classes.
2019-12-05 saugustine Revert "[AST] Traverse the class type loc inside the member type loc."
2019-12-03 tejohnson [ThinLTO] Add option to disable readonly/writeonly attribute propagation
2019-12-04 qcolombet [RegisterCoalescer] Fix the creation of subranges when rematerialization is used
2019-12-05 rnk Handle two corner cases in creduce-clang-crash.py
2019-11-24 aktoon [AutoFDO] Top-down Inlining for specialization with context-sensitive profile
2019-11-24 aktoon [AutoFDO] Properly merge context-sensitive profile of inlinee back to outlined function
2019-12-05 llvmgnsyncbot gn build: Merge fdf80e86a52
2019-12-06 saar [Concepts] Fix build failures in D41569
2019-12-05 rupprecht [lldb] Update hardcoded Makefile.rules inclusions.
2019-12-06 saar [Concepts] Constraint Enforcement & Diagnostics
2019-12-05 maskray [IR] Move ctor in the NDEBUG branch
2019-12-05 maskray [IR] Add a default copy constructor for -Wdeprecated-copy
2019-12-05 richard Properly convert all declaration non-type template arguments when forming non-type template parameter values.
2019-12-05 echristo Add a default copy constructor for -Wdeprecated-copy warnings.
2019-12-05 jonathanchesterfield [libomptarget][nfc] Introduce SHARED, ALIGN macros
2019-12-05 aprantl Debug Info: Apply a default location for cleanups if none is available.
2019-12-05 dblaikie DebugInfo: Fix LTO+DWARFv5 loclists
2019-12-05 aprantl Debug Info: Assert that location is available for cleanups
2019-12-05 aprantl Set a source location for Objective-C accessor stubs even when there is no explicit synthesize statement.
2019-12-05 jonathanchesterfield [libomptarget][nfc] Move omptarget-nvptx under common
2019-12-05 daltenty [AIX] Make sure to use QualNames for external global objects
2019-12-05 aaron Add documentation headings for the OpenCL attributes.
2019-12-05 cchen [OpenMP50] Add parallel master construct
2019-12-04 akhuang Use diff -b on zlib tests so they pass on Windows
2019-12-05 zeratul976 [clangd] Highlighting dependent types in more contexts
2019-12-05 zeratul976 [clangd] Find reference to template parameter in 'sizeof...' expression
2019-12-05 flo Revert "[DSE] Fix for a dangling point bug in DeadStoreElimination."
2019-11-25 eugenis LowerDbgDeclare: look through bitcasts.
2019-12-05 peter scudo: Fix one of the C wrapper tests on Android.
2019-11-19 peter scudo: Fix the build of wrappers_c_test.cpp on Android.
2019-12-05 vkeles [GlobalISel] Localizer: Allow targets not to run the pass conditionally
2019-12-05 craig.topper [X86] Remove ProcIntelGLM/ProcIntelGLP/ProcIntelTRM and replace them with a single feature flag covers the two places they were used.
2019-12-02 llvm Revert "[InstCombine] keep assumption before sinking calls"
2019-12-05 a.bataev [OPENMP50]Add support for if clause for simd part in distribute parallel for simd directive.
2019-12-05 lebedev.ri [InstCombine] Invert `add A, sext(B) --> sub A, zext(B)` canonicalization (to `sub A, zext B -> add A, sext B`)
2019-12-02 maskray [ELF][PPC64] Support long branch thunks with addends
2019-12-05 Sanne.Wouda [AArch64] Fix MUL/SUB fusing
2019-12-05 syaghmour [LLDB] Replacing use of ul suffix in GetMaxU64Bitfield since it not guarenteed to be 64 bit
2019-11-28 puyan [llvm] llvm-ifs: Support for handling empty IFS and merging weak+strong symbols.
2019-12-05 quic_aankit [DSE] Fix for a dangling point bug in DeadStoreElimination.
2019-12-02 maskray [ELF][PPC64] Don't copy ppc64BranchltIndex in replaceWithDefined
2019-12-05 xazax [scan-build-py] Set of small fixes
2019-12-05 1.int32 [ASTImporter] Various source location and range import fixes.
2019-12-05 a.bataev [OPENMP50]Add support for if clause for simd part in parallel master taskloop simd directive.

Roll third_party/dxc/ c5df9d33e..b0731e7f2 (1 commit)

microsoft/DirectXShaderCompiler@c5df9d3...b0731e7

$ git log c5df9d33e..b0731e7f2 --date=short --no-merges --format='%ad %ae %s'
2019-12-06 ehsannas [spirv] Cleanup: Remove SPIRV hybrid function type. (#2620)

Roll third_party/glslang/ 0de87ee9a..ff61c18f1 (2 commits)

KhronosGroup/glslang@0de87ee...ff61c18

$ git log 0de87ee9a..ff61c18f1 --date=short --no-merges --format='%ad %ae %s'
2019-12-09 cepheus Fix #2007: Fix a couple relative header paths in header files.
2019-12-09 cepheus Fix #1993: Fully exclude ftransform() from SPIR-V semantics.

Roll third_party/googletest/ ae8d1fc81..78fdd6c00 (6 commits)

google/googletest@ae8d1fc...78fdd6c

$ git log ae8d1fc81..78fdd6c00 --date=short --no-merges --format='%ad %ae %s'
2019-12-05 absl-team Googletest export
2019-12-05 absl-team Googletest export
2019-12-05 absl-team Googletest export
2019-11-27 krystian.kuzniarek Revert "remove MSVC workaround: wmain link error in the static library"
2019-11-27 krystian.kuzniarek Revert "unify googletest and googlemock main functions"
2019-11-17 krystian.kuzniarek remove MSVC workaround: cease const dropping

Roll third_party/lodepng/ dc3f19b5a..2e541f53e (2 commits)

lvandeve/lodepng@dc3f19b...2e541f5

$ git log dc3f19b5a..2e541f53e --date=short --no-merges --format='%ad %ae %s'
2019-12-08 lvandeve make auto_choose_color static since it's only internal
2019-12-08 amirgonnen Remove lodepng_auto_choose_color prototype

Roll third_party/shaderc/ f9278b9cb..eec373d9e (3 commits)

google/shaderc@f9278b9...eec373d

$ git log f9278b9cb..eec373d9e --date=short --no-merges --format='%ad %ae %s'
2019-12-05 dneto Apply Python linter advice (#928)
2019-12-05 dneto Apply clang-tidy advice (#930)
2019-12-05 rharrison Rolling 4 dependencies & updating expectations (#929)

Roll third_party/spirv-tools/ e82a42860..983b5b4fc (1 commit)

KhronosGroup/SPIRV-Tools@e82a428...983b5b4

$ git log e82a42860..983b5b4fc --date=short --no-merges --format='%ad %ae %s'
2019-12-06 afdx spirv-fuzz: Use validator to check break/continue dominance conditions (#3089)

Roll third_party/swiftshader/ 2b9e22ac6..84d0f7cbb (13 commits)

https://swiftshader.googlesource.com/SwiftShader.git/+log/2b9e22ac6c80..84d0f7cbbb9b

$ git log 2b9e22ac6..84d0f7cbb --date=short --no-merges --format='%ad %ae %s'
2019-11-05 amaiorano Revert "Fix materialization of function arguments"
2019-12-09 bclayton Kokoro: Add ReactorUnitTests to windows presubmits
2019-12-07 capn Remove coverage asserts for tested code
2019-12-06 digit [Subzero] Remove assert that breaks Shuffle operations.
2019-12-03 bclayton SpirvShader: Use struct for MemoryVisitor callback.
2019-12-06 bclayton Regres: Update dEQP to include fence timeout fix.
2019-12-03 bclayton Vulkan: Tidy VkCommandBuffer.cpp
2019-12-06 bclayton Reactor: Rename Blend() to Shuffle()
2019-12-06 swiftshader.regress Regres: Update test lists @ b9f03f47
2019-12-05 bclayton Reactor: Switch swizzles over to 16-bit hex codes
2019-12-04 digit [vulkan] Add VK_SUBGROUP_FEATURE_ARITHMETIC_BIT support
2019-08-12 bclayton Vulkan: Optimize shaderClipDistance and shaderCullDistance
2019-08-09 bclayton Vulkan: Implement shaderClipDistance and shaderCullDistance

Roll third_party/vulkan-headers/ 2b89fd4e2..0e57fc1cf (1 commit)

KhronosGroup/Vulkan-Headers@2b89fd4...0e57fc1

$ git log 2b89fd4e2..0e57fc1cf --date=short --no-merges --format='%ad %ae %s'
2019-12-09 oddhack Update for Vulkan-Docs 1.1.130

Roll third_party/vulkan-loader/ 2d6f74c6d..6ec1838ba (1 commit)

KhronosGroup/Vulkan-Loader@2d6f74c...6ec1838

$ git log 2d6f74c6d..6ec1838ba --date=short --no-merges --format='%ad %ae %s'
2019-12-05 thakis Fix a bug found by clang's -Wsizeof-array-div.

Roll third_party/vulkan-validationlayers/ e72b61c7c..f34b9fb08 (5 commits)

KhronosGroup/Vulkan-ValidationLayers@e72b61c...f34b9fb

$ git log e72b61c7c..f34b9fb08 --date=short --no-merges --format='%ad %ae %s'
2019-12-06 jeremy Remove default initialized push constant ranges
2019-12-03 mark tests: Add imageless framebuffer positive test
2019-12-03 mark statetracker: Avoid bad derefs for imageless framebuffer cases
2019-12-03 mark tests: Add tests for CmdFillBuffer offset and size
2019-12-03 mark corechecks: Add offset/size checks for CmdFillBuffer

Created with:
  roll-dep third_party/clspv third_party/clspv-llvm third_party/dxc third_party/glslang third_party/googletest third_party/lodepng third_party/shaderc third_party/spirv-headers third_party/spirv-tools third_party/swiftshader third_party/vulkan-headers third_party/vulkan-loader third_party/vulkan-validationlayers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dneto0 dneto0 dneto0 approved these changes

@hevrard hevrard Awaiting requested review from hevrard

Assignees

@dj2 dj2

Labels

refactoring Cleanup work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dj2 @dneto0