[WIP] Update code to catch up with Dawn updates#552
Closed
sarahM0 wants to merge 1 commit intogoogle:masterfrom
Closed
[WIP] Update code to catch up with Dawn updates#552sarahM0 wants to merge 1 commit intogoogle:masterfrom
sarahM0 wants to merge 1 commit intogoogle:masterfrom
Conversation
dneto0
reviewed
Jun 19, 2019
| vertexInput.stepMode = ::dawn::InputStepMode::Vertex; | ||
| for (uint32_t i = 0; i < kMaxVertexInputs; ++i) { | ||
| tempInputs[i] = vertexInput; | ||
| vertexInputDescriptor = new ComboVertexInputDescriptor(); |
Collaborator
There was a problem hiding this comment.
It seems unusual to have an allocation of this object, and then hand ownership over to the Dawn API. I guess this leaks. I would expect this to be allocated on the stack and you pass in the address to the .vertexInput member of renderPipelineDiscriptor ??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: please do not review
fixes: #550