Skip to content

Remove fragment shader requirement from validation#555

Merged
dneto0 merged 4 commits intogoogle:masterfrom
sarahM0:val
Jun 18, 2019
Merged

Remove fragment shader requirement from validation#555
dneto0 merged 4 commits intogoogle:masterfrom
sarahM0:val

Conversation

@sarahM0
Copy link
Contributor

@sarahM0 sarahM0 commented Jun 18, 2019

fixes: #553

@sarahM0 sarahM0 requested a review from dneto0 June 18, 2019 17:37
@sarahM0
Copy link
Contributor Author

sarahM0 commented Jun 18, 2019

CI-ubuntu-gcc-debug-dawn is failing because of some git clone issues:
subprocess.CalledProcessError: Command '['git', 'clone', '--quiet', 'https://github.com/lvandeve/lodepng.git', 'third_party/lodepng']' returned non-zero exit status 128.
subprocess.CalledProcessError: Command '['git', 'clone', '--quiet', 'https://github.com/KhronosGroup/SPIRV-Headers.git', 'third_party/spirv-headers']' returned non-zero exit status 128.

@dneto0
Copy link
Collaborator

dneto0 commented Jun 18, 2019

Yes, GitHub has been flaky for me today as well.
Thanks for fixing this before I noticed!

@dneto0 dneto0 merged commit fce7244 into google:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validator might falsely fail requiring fragment shader

2 participants