Skip to content

Set the element count so we'll know the max size of a ssbo #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarahM0 merged 4 commits into from
Jun 25, 2019
Merged

Set the element count so we'll know the max size of a ssbo #562

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72edbf0
set max element count
sarahM0 Jun 24, 2019
e9d4ac3
fix implicit casting error
sarahM0 Jun 25, 2019
0f42bc0
count in offset
sarahM0 Jun 25, 2019
cb2c11a
don't set the data
sarahM0 Jun 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/vkscript/command_parser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,22 @@ Result CommandParser::ProcessSSBO() {
if (!r.IsSuccess())
return r;

// Multiply by the input needed because the value count will use the needed
// input as the multiplier
uint32_t value_count =
((cmd->GetOffset() / buf->GetFormat()->SizeInBytes()) *
buf->GetFormat()->InputNeededPerElement()) +
static_cast<uint32_t>(values.size());
// The buffer should only be resized to become bigger. This means that if a
// command was run to set the buffer size we'll honour that size until a
// request happens to make the buffer bigger.
if (value_count > buf->ValueCount())
buf->SetValueCount(value_count);

// Even if the value count doesn't change, the buffer is still resized
// because this maybe the first time data is set into the buffer.
buf->ResizeTo(buf->GetSizeInBytes());

cmd->SetValues(std::move(values));

} else {
Expand Down