Set entry point names during pipeline creation#577
Merged
alan-baker merged 4 commits intogoogle:masterfrom Jul 15, 2019
Merged
Conversation
* When vulkan::Pipeline is created set the entry point names for all shaders that have had the entry point specified * add a test that previously failed
dneto0
approved these changes
Jul 15, 2019
jaebaek
approved these changes
Jul 15, 2019
| if (!r.IsSuccess()) | ||
| return r; | ||
| const auto& name = shader_info.GetEntryPoint(); | ||
| if (!name.empty()) { |
Contributor
There was a problem hiding this comment.
If it is empty, it would be better to just return an error here?
if (name.empty())
return Result("Vulkan: pipeline entry point is empty");
info.vk_pipeline->SetEntryPointName(stage, name);
Collaborator
Author
There was a problem hiding this comment.
It is valid to not set an entry name if you plan to use the default name.
dj2
reviewed
Jul 16, 2019
|
|
||
| END | ||
|
|
||
| BUFFER in_buf DATA_TYPE uint32 DATA |
Collaborator
There was a problem hiding this comment.
For future note, this could have been a single line:
BUFFER in_buf DATA_TYPE uint32 DATA 9 END
dj2
reviewed
Jul 16, 2019
|
|
||
| RUN my_pipeline 1 1 1 | ||
|
|
||
| EXPECT out_buf EQ_BUFFER in_buf |
Collaborator
There was a problem hiding this comment.
Awesome, nice to see EQ_BUFFER being useful for tests. @hevrard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously pipeline names were only set if there was an entry point command executed. This doesn't match up with how AmberScript specifies entry point names.
Now, if the entry point name was specified in the attach command, it will get set at pipeline creation.