Allow recipe to change fence timeout.#624
Allow recipe to change fence timeout.#624dj2 merged 2 commits intogoogle:masterfrom dj2:fence_timeout
Conversation
This CL adds an API to the recipe class to set the fence timeout for a given script. The default fence timeout is also bumped from 100ms to 1000ms.
|
Looks perfect for our needs, thank you! |
|
|
||
| /// Sets the fence timeout to |timeout_ms|. | ||
| void SetFenceTimeout(uint32_t timeout_ms) override { | ||
| engine_data_.fence_timeout_ms = timeout_ms; |
There was a problem hiding this comment.
This breaks the abstraction. Setting the fence timeout on one script will change the timeout for all other scripts running on that engine.
Instead you should have the executor get the timeout from the script when the script is being executed, then apply it when the script is executed.
There was a problem hiding this comment.
Line 56 in 64b6362
The engine has the data set from the script when the script executes.
There was a problem hiding this comment.
engine data is per script
|
Gentle ping. |
|
Kokoro doesn't seem to be showing the details links anymore so I can't see why the dawn build failed .... |
|
The failure is because of a new change in dawn buffer UsageBit (not changes in this PR). I'll put up a fix for it shortly. |
|
Awesome, thanks Sarah. @dneto0 can you take another look please. |
4 participants
This CL adds an API to the recipe class to set the fence timeout for a
given script.
The default fence timeout is also bumped from 100ms to 1000ms.