Workaround for GCC 11 uninit variable warnings#946
Merged
paulthomson merged 1 commit intogoogle:mainfrom Apr 7, 2021
Merged
Conversation
Building Amber with GCC 11.0.1 produces some uninitialized variable warnings. This commit works around them by replacing reinterpret_cast with memcpy when type punning unsigned integers to floats.
paulthomson
approved these changes
Apr 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release builds of Amber (and the CTS) with GCC 11.0.1 produce some uninitialized variable warnings:
I'm not sure if this is a bug in GCC. This commit works around the warnings by replacing reinterpret_cast with memcpy when type punning unsigned integers to floats. At least on GCC the generated code should be unchanged compared to the current approach:
There's also a new stringop-truncation warning in SPIRV-tools which affects building Amber but not the CTS.