Check error return when pushing descriptors#980
Merged
paulthomson merged 2 commits intogoogle:mainfrom Mar 21, 2022
Merged
Conversation
Pipeline::SendDescriptorDataToDeviceIfNeeded was not checking the error return when initializing transfer buffers, which can lead to later code attempting to use invalid buffers and crashing.
Contributor
Author
|
@paulthomson is there a process for getting this PR reviewed? It's causing problems for us in the Vulkan CTS. Thanks. |
paulthomson
approved these changes
Mar 21, 2022
Collaborator
|
Sorry, I missed this. Just merging main into your branch now, and then I can merge. |
Contributor
Author
|
Great. No problem. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline::SendDescriptorDataToDeviceIfNeeded was not checking the error
return when initializing transfer buffers, which can lead to later code
attempting to use invalid buffers and crashing.