Arrange for the Gradle integration test to run in the install phase.#1457
Closed
copybara-service[bot] wants to merge 1 commit intomainfrom
Closed
Arrange for the Gradle integration test to run in the install phase.#1457copybara-service[bot] wants to merge 1 commit intomainfrom
install phase.#1457copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
Bot
force-pushed
the
test_main_511051082
branch
5 times, most recently
from
01abe95 to
829da22
Compare
I am not sure how this test worked before. I think it happened to work as a side effect of other integration tests installing the `HEAD-SNAPSHOT` artifacts, which we stopped doing in #1451. It happens that we noticed the breakage with a Dependabot [PR](#1452) to update `gradle-test-kit`, but I think the CI was already broken. Anyway, the Gradle test assumes it can depend on the artifacts for the current AutoValue version, and those are only available in the `install` phase. By following the Maven convention whereby regular unit tests are called `FooTest` and integration tests are called `FooIT`, we get the right tests run in the right phases without having to specify `<include>` and the like. RELNOTES=n/a PiperOrigin-RevId: 511051082
copybara-service
Bot
force-pushed
the
test_main_511051082
branch
from
829da22 to
2daaaa7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arrange for the Gradle integration test to run in the
installphase.I am not sure how this test worked before. I think it happened to work as a side effect of other integration tests installing the
HEAD-SNAPSHOTartifacts, which we stopped doing in #1451. It happens that we noticed the breakage with a Dependabot PR to updategradle-test-kit, but I think the CI was already broken.Anyway, the Gradle test assumes it can depend on the artifacts for the current AutoValue version, and those are only available in the
installphase.By following the Maven convention whereby regular unit tests are called
FooTestand integration tests are calledFooIT, we get the right tests run in the right phases without having to specify<include>and the like.RELNOTES=n/a