Conversation
Member
Author
|
@adambadura is this what you were thinking for the docs for ctest? |
adambadura
reviewed
Aug 19, 2020
LebedevRI
reviewed
Aug 19, 2020
Added note to use parallel and cleaned build config notes
adambadura
reviewed
Aug 20, 2020
adambadura
reviewed
Aug 20, 2020
adambadura
reviewed
Aug 20, 2020
LebedevRI
reviewed
Aug 21, 2020
LebedevRI
approved these changes
Aug 21, 2020
Member
Author
|
will merge once CI completes. |
JBakamovic
pushed a commit
to JBakamovic/benchmark
that referenced
this pull request
Sep 11, 2020
* ctest is now working * Update README * remove commented out lines * Tweaked docs Added note to use parallel and cleaned build config notes * Response to comments * revert all but the readme * make error message clearer * drop --parallel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1023
just a docs change after all