Fix realtime measurement for multi-threaded benchmarks#1030
Closed
krzikalla wants to merge 2 commits intogoogle:masterfrom
Closed
Fix realtime measurement for multi-threaded benchmarks#1030krzikalla wants to merge 2 commits intogoogle:masterfrom
krzikalla wants to merge 2 commits intogoogle:masterfrom
Conversation
Collaborator
|
@krzikalla thank you for looking into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to quick-fix the wall-clock time (real time) as discussed in PR #946. This is a prerequiste for adding some tests in PR #1027.
However, the changes now seriously overlap with PR #946 (esp. the change in line
benchmark/src/benchmark_runner.cc
Line 125 in 5c25ad3
I realized, that a lot of design questions must be answered before we can go on with #946 and this one.
benchmark/include/benchmark/benchmark.h
Lines 553 to 554 in 5c25ad3
@koct9i : Maybe you can use my tests as a template for your PR.