Skip to content

Fix realtime measurement for multi-threaded benchmarks#1030

Closed
krzikalla wants to merge 2 commits intogoogle:masterfrom
krzikalla:realtime_fix
Closed

Fix realtime measurement for multi-threaded benchmarks#1030
krzikalla wants to merge 2 commits intogoogle:masterfrom
krzikalla:realtime_fix

Conversation

@krzikalla
Copy link
Contributor

@krzikalla krzikalla commented Aug 25, 2020

I tried to quick-fix the wall-clock time (real time) as discussed in PR #946. This is a prerequiste for adding some tests in PR #1027.
However, the changes now seriously overlap with PR #946 (esp. the change in line

results.iterations += st.iterations();
).

I realized, that a lot of design questions must be answered before we can go on with #946 and this one.

  1. Do we allow a different iteration count across threads. (IMHO no and I'd check this) If yes: what results are reported then? What are their meanings?
  2. How is manual timing handled in multi-threaded benchmarks? IMHO the current implementation does not match the comment at
    // For threaded benchmarks the final value will be set to the largest
    // reported values.
    IMHO and according to the comment it should be handled similar to real time.
  3. Which values are written in which mode and what is their meaning? (default/real time/manual time * default/ProcessCPUTime)

@koct9i : Maybe you can use my tests as a template for your PR.

@google-cla google-cla bot added the cla: yes label Aug 25, 2020
@LebedevRI
Copy link
Collaborator

@krzikalla thank you for looking into this.

@dmah42 dmah42 added the incomplete work needed label May 6, 2021
@dmah42 dmah42 closed this May 30, 2021
@dmah42 dmah42 deleted the branch google:master May 30, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants