Skip to content

Conversation

@turbocool3r
Copy link

Fixes build on macOS and also updates binaryninja-api to the latest stable version.

On macOS using ProcessPoolExecutor for some reason caused behdict to be empty. This changes ProcessPoolExecutor to ThreadPoolExecutor. Using it doesn't make much sense since there is GIL, but at least it works fine.

@google-cla
Copy link

google-cla bot commented Nov 7, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@droptopx
Copy link

I believe behdict is empty as a result of ProcessPoolExecutor using spawn by default (where all resources aren't inherited by the child processes) on macOS instead of fork. Passing an mp_context=mp.get_context("fork") to the ProcessPoolExecutor fixes this issue but this is considered unsafe on macOS as it can cause crashes. Seems to work without crashes for this use case though.

@cfircohen
Copy link
Contributor

Sorry for the (very) late response. I can't test on a macOS, but happy to accept a PR that fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants