Skip to content

Conversation

@clark-ja
Copy link

As the title says, this PR makes the binja-hexagon architecture plugin compatible to the newest binaryninja API and fixes some bugs.

Changes:

  • update binaryninja-api submodule (to latest dev commit)
  • update abseil-cpp submodule (to latest LTS)
  • add string.h include to third party qemu-hexagon module
  • fix the order of children and meta arguments in python functions decorated with lark @v_args(meta=True) decorators (view also Improve documentation of v_args meta option. lark-parser/lark#1302)

Tested and working with Binary Ninja 4.3.6676-dev Personal on Linux

@google-cla
Copy link

google-cla bot commented Jan 15, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@clark-ja
Copy link
Author

Oh, and if that is preferred, I can also change the binaryninja-api submodule to the latest stable version instead.

Copy link
Contributor

@cfircohen cfircohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@cfircohen
Copy link
Contributor

Looks like I can no longer push to main, I'll see if I can find a Googler to own this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants