Skip to content
This repository was archived by the owner on Nov 14, 2022. It is now read-only.

Clean bgit#9

Open
Androbin wants to merge 1 commit intogoogle:masterfrom
Androbin:patch-1
Open

Clean bgit#9
Androbin wants to merge 1 commit intogoogle:masterfrom
Androbin:patch-1

Conversation

@Androbin
Copy link

@Androbin Androbin commented Nov 20, 2017

read without -r will mangle backslashes.
Use "$@" (with quotes) to prevent whitespace problems.
Quote the grep pattern so the shell won't interpret it.
Consider using grep -c instead of grep|wc -l.
Double quote array expansions to avoid re-splitting elements.


This change is Reviewable

read without -r will mangle backslashes.
Use "$@" (with quotes) to prevent whitespace problems.
Quote the grep pattern so the shell won't interpret it.
Consider using grep -c instead of grep|wc -l.
Double quote array expansions to avoid re-splitting elements.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant