Skip to content

Conversation

@kojiishi
Copy link
Collaborator

This patch supports non-breaking content in the JavaScript HTMLProcessor. The non-breaking content provides context for the Parser but the content is not breakable.

Contents with white-space: nowrap and white-spce: pre are handled as non-breaking content. The <nobr> element is also supported; this is useful for disconnected tree when all styles including white-space are not computed.

@kojiishi kojiishi requested a review from tushuhei August 14, 2023 10:42
@kojiishi
Copy link
Collaborator Author

PTAL.

@kojiishi kojiishi force-pushed the nobr branch 2 times, most recently from 7c27101 to 45e82f3 Compare August 14, 2023 10:48
tushuhei
tushuhei previously approved these changes Aug 15, 2023
This patch supports non-breaking content in the JavaScript `HTMLProcessor`. The non-breaking content provides context for the Parser but the content is not breakable.

Contents with `white-space: nowrap` and `white-spce: pre` are handled as non-breaking content. The `<nobr>` element is also supported; this is useful for disconnected tree when all styles including `white-space` are not computed.
@kojiishi
Copy link
Collaborator Author

PTAL, mistakenly used --amend that I had to push force, sorry about this.

@tushuhei tushuhei merged commit ce2eda8 into google:main Aug 15, 2023
@kojiishi kojiishi deleted the nobr branch August 17, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants