Skip to content

Specify maxsplit to handle colon symbols properly #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tushuhei merged 2 commits into from
Aug 15, 2023
Merged

Specify maxsplit to handle colon symbols properly #247

tushuhei merged 2 commits into from
Aug 15, 2023

Conversation

@tushuhei
Copy link
Member

@tushuhei tushuhei commented Aug 15, 2023

No description provided.

@tushuhei tushuhei requested a review from kojiishi August 15, 2023 01:19
kojiishi
kojiishi previously approved these changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@kojiishi kojiishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a nit.

@tushuhei tushuhei requested a review from kojiishi August 15, 2023 11:41
@tushuhei tushuhei changed the title Replace split with partition to handle colon symbols Specify maxsplit to handle colon symbols properly Aug 15, 2023
@tushuhei tushuhei merged commit 613ba71 into main Aug 15, 2023
@tushuhei tushuhei deleted the colon-partition branch December 12, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kojiishi kojiishi Awaiting requested review from kojiishi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tushuhei @kojiishi